search

playbenny / benny

a live music environment
Other
65 stars 3 forks source link

midi->audio translator rare stack overflow bug #346

Open jamesholdenmusic opened 3 months ago

jamesholdenmusic commented 3 months ago

bennyRung1.json this file causes it, after a while. it's the midi->audio connection.

mattlinares commented 3 months ago

What's to be done? Test and try again?

jamesholdenmusic commented 3 months ago

actually i couldn't recreate? i'm wondering if it was a specific state it got into because of that accidental mic -> mic block voice mute connection you'd made before (which is now prevented by the connections page) so i'm wondering does this savefile still do it on your computer?

mattlinares commented 3 months ago

Seems to work ok currently but I'll test with the mic and see if it happens (I can't remember what the bug actually ended up doing).

jamesholdenmusic commented 3 months ago

it made a stack overflow happen when that specific bit of gen in the midi router patcher (that fetches midi messages that will become audio from a buffer and outputs them) reached the end of the ring buffer it gets messages out of - i think that's 1024 messages long and iirc your patch looped through it about once a minute - so if no lockup after 10 minutes it's not going to happen? the mic thing you did was connect it to a destination that doesn't really exist - per voice mute for the mic block - and that's now impossible but could've caused it (by writing bad data into the aforementioned ring buffer perhaps?)

mattlinares commented 3 months ago

@jamesholdenmusic this just happened again. on latest version

mattlinares commented 3 months ago

Getting this again in a different setting, can't save the file..

Screenshot 2024-05-24 at 17 17 46

jamesholdenmusic commented 3 months ago

well done. in order to save, in the error at the top of the launcher window click 'prepend' and it'll take you to that max window, delete the highlighted 'prepend' object, go back and clear the error message with the X at the end of it, you should be able to save

On Fri, 24 May 2024 at 17:20, Matthew Linares @.***> wrote:

Getting this again in a different setting, can't save the file..

Screenshot.2024-05-24.at.17.17.46.png (view on web) https://github.com/jamesholdenmusic/benny/assets/71731/7be67900-5eae-41e5-8fbc-e433476ed402

— Reply to this email directly, view it on GitHub https://github.com/jamesholdenmusic/benny/issues/346#issuecomment-2129931863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWRHOAMZYJIA2UFWNSJVX43ZD5SDJAVCNFSM6AAAAABHTCMRG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZHEZTCOBWGM . You are receiving this because you were mentioned.Message ID: @.***>