playbenny / benny

a live music environment
Other
65 stars 3 forks source link

save doesn't overwrite current file with same name #389

Closed GenerativePanda closed 4 weeks ago

GenerativePanda commented 3 months ago

macbook air os12.5 m1 (2020)

possible bug (possible user error)

open Benny, click files, load, load file (derwin_benny05), change all params, add new blocks etc, click files, save. on next load (derwin_benny05) hasn't been overwritten.

current workaround: save as > overwrite (derwin_benny05).

jamesholdenmusic commented 3 months ago

thanks derwin as you wrote this i was discovering that an issue to do with save (not save as) had made a mess of every song in my liveset. something to do with it not actually collecting everything up before writing to disk.. so this could be the same thing - it's just saving the old version of the song not the new stuff because it hasn't collected that up yet?

or it could be a new mystery mac-only issue with saving files that i haven't hit yet?

if you get a chance could you: do the above steps, as far as the save. then have a look does the last modified time on the file change? and if so (check the time straight after saving), if you save again 20 seconds after the first save, does that one work properly?

if that doesn't work i'm curious also: ctrl-s should save as a new file with an incrementing number - like song 1, song 2, song 3, etc. though the naming algorithm is cursed at the moment. does that successfully write a new file to disk?

jamesholdenmusic commented 3 months ago

ok disregard some of the above - i've tried to make sure it gets its stuff done before it saves for save / ctrl-s. latest version, does it now work?

GenerativePanda commented 3 months ago

So, additional stuff. I can only open whats in "demo songs", there doesn't seem to be a way to access different folders to load from. Although I can "save_as" to anywhere. I just can't find it from benny's menu to open again.

So I'm saving in demosongs for now. I got the latest proj and tried out the save and this is what happens.

the file I'm using is "derwin_benny6.json" in the "demo folder", I click "save". nothing new is generated in the "save/load menu". BUT in the "benny-main" folder I get demosongsderwin_benny6.json demosongsdemosongsderwin_benny6.json demosongsdemosongsdemosongsderwin_benny6.json (etc etc...)

Sometimes "save selected" appears and sometimes it doesn't.

jamesholdenmusic commented 3 months ago

that's interesting! and confusing. thanks!

could you attach (here) your 'userconfig.json' from the benny folder?

save selected should appear any time you have some blocks selected, but not otherwise (would having it grey out instead of vanish be more intuitive?)

if you hold ctrl then the folder button turns into a 'choose folder' and the load button turns into 'load from elsewhere'.

still thinking about ways to make this understandable without making it less streamlined.. (on stage the one-folder-of-songs-all-preloaded-in-memory thing feels pretty good, so i don't want to detract from that)

GenerativePanda commented 3 months ago

userconfig.json

GenerativePanda commented 3 months ago

...(on stage the one-folder-of-songs-all-preloaded-in-memory thing feels pretty good, so i don't want to detract from that)

yes that is totally great imo