search

playbenny / benny

a live music environment
Other
65 stars 3 forks source link

mystery rare param alteration on load bug #456

Closed jamesholdenmusic closed 1 month ago

jamesholdenmusic commented 1 month ago

in very rare cases a parameter (the 1st?) - in this case of a vst - will be set to the wrong value after load. only when another patch is already loaded. the init value is correctly retrieved and set (and stored as the alt-click default) but sometime after that something is setting the param to the wrong value (a low number).

example: blackpool -> in the end you'll know. 64 / 64, wedge case.

it's not: coming from the vst itself it's not mix.ui, i think it's not controllermanager.js, it's not something calling the js param-setting fns (eg via voicemanager)

jamesholdenmusic commented 1 month ago

ok so: buckets, in response to a parameter changing, will trigger a delay time button. loading the vst into the slot that was buckets triggered this, which sets param 0 of that voice to a value corresponding to that delay time button. but it shouldn't - both the parameter tracking should be off and the request-set-block-parameter input should be off too. enabled 0 hasn't got through when the block was unloaded by clear everything. clear everything twice does make it work tho.

jamesholdenmusic commented 1 month ago

proof of this - delete the buckets block in blackpool, then load next one, bug doesn't occur.

caught it - was 'update all voices mute status' was missing a -MAX_NOTE_VOICES in an index and wasn't treating recycled blocks as such.