playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
154 stars 28 forks source link

When we press enter for input elements, disable focus #1008

Closed devcem closed 1 year ago

devcem commented 1 year ago

That was the face before the update, but for some reason this doesn't work. Please bring this feature back. I always find myself in a situation where I have some number and f in input.

willeastcott commented 1 year ago

Sorry, can you clarify the problem here please? You're saying there's a regression in PCUI?

yaustar commented 1 year ago

I've hit this issue but not sure if it's a regression or not. I'm pretty sure I used to be able to press enter when in a number field and then the input field no longer had focus. So I could press f to focus on the current object

slimbuck commented 1 year ago

Yes I've noticed this too. I was able to set scale x, y, z easily in the editor by selecting x then tabbing to y and z. After setting z I could press enter and continue working.

That doesn't work anymore. Pressing enter then f results in scale.z being reset to 0.

willeastcott commented 1 year ago

Really sorry about this @devcem - I only just got around to investigating this and I believe I've submitted the appropriate fix: https://github.com/playcanvas/pcui/pull/316

Assuming that's approved soon, I'll merge it and get it deployed for you.

willeastcott commented 1 year ago

The fix is now deployed @devcem - give it a try and see! 😄