search

playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
154 stars 28 forks source link

Firefox - Code Editor not functioning as expected #1050

Closed defektu closed 1 year ago

defektu commented 1 year ago

Description

While opening script, every script selected from Editor UI opens a new window instead of appending to tabs query. Opening new script assets from Code Editor UI works as expected.

Affected Browser: Firefox

Expected Behavior

https://playcanvas.com/editor/code/{projectID}?tabs={assetID},{assetID},{assetID}

Current Behavior

https://playcanvas.com/editor/code/{projectID}?tabs={assetID} https://playcanvas.com/editor/code/{projectID}?tabs={assetID}

Possible Cause

NS_BINDING_ABORTED Saw this error at network tab in Editor UI. Possibly related to window.location.replace

Screenshots

image

Steps to Reproduce

  1. Open a project in Firefox
  2. Double click to open a script (or click edit on script tab of entity)
  3. Switch to Editor UI double click another script (or same script)
  4. It will open a new Code Editor window
willeastcott commented 1 year ago

@defektu The fix for this is now live. Can you confirm things are now working as you would expect?

defektu commented 1 year ago

@willeastcott Working flawlessly.