search

playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
154 stars 28 forks source link

Private project Sign-in Flow Issue #1064

Open defektu opened 10 months ago

defektu commented 10 months ago

There is a redirect loop that I experienced in login flow in private projects redirected from launch links.

If you have a link with private project and you logged out somehow (cookie expiration, manual sign out etc) it ask you to login. When you login it redirects you to 404.

Reproduction

  1. https://launch.playcanvas.com/{scene-id}
  2. Redirects to https://login.playcanvas.com/?came_from=https%3A%2F%2Fplaycanvas.com%2Feditor%2Fscene%2F{scene-id}%2Flaunch
  3. Login
  4. Redirects to https://playcanvas.com/editor/scene/{scene-id}/launch

Extras

Queries are not redirecting too.

Expected Behaviour

On step 4. should redirect to https://launch.playcanvas.com/{scene-id} with queries.

LeXXik commented 10 months ago

Had this issue today, actually. Had a private project opened in one of the mobile phone tabs for ages. The login expired. Refreshing the page (editor) opens login view (with a blocking keyboard (Safari), couldn't hide it to reveal the login with Google under it). After refreshing the login view, I could scroll again (and keyboard was unlocked) and was able to login. Did log in to 404, though, so had to manually edit the URL to return to the projects list and select the project again.