playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
160 stars 28 forks source link

"Used" assets does not respect script attributes anymore #1170

Open Maksims opened 4 months ago

Maksims commented 4 months ago

"Used" assets, is very useful feature for two use cases:

  1. Clean up projects and identify what is really used (referenced) and what is not.
  2. Replace assets with other versions using context menu > Replace.

This works for most asset slots, bit it has issues in two places:

  1. Script array attributes. It identifies that asset is used when Editor is loaded, but any modifications to script attributes (adding/removing etc) of this asset, does not update asset "used" state.
  2. Script attribute "json" type, and json array type. If schema includes "asset" type, referencing assets that way does not affect "used" state at all.
willeastcott commented 4 months ago

Just to be clear, this is not a regression, right? You're just pointing out some longstanding problems with this feature?

Maksims commented 4 months ago

I don't know if it is regression or wasn't implemented initially, just expected it to work.