playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
154 stars 28 forks source link

Editor red UI text hard to read on dark background #140

Open LeXXik opened 3 years ago

LeXXik commented 3 years ago

I would like to ask for enhancement for used colors in the Editor. For example: image

There is an error message at the bottom that uses a shade of red that is almost not visible on the grey background for colorblind people like I am. I would like to request to use colorblind-safe color matches.

willeastcott commented 3 years ago

Hey @rawkas, what would you advise here?

LeXXik commented 3 months ago

This is still an issue ;) Most of the error messages are not intelligible for us poor colorblind peeps.

willeastcott commented 3 months ago

Sorry this issue has not been addressed by now. So this is what things look like now:

d34141;

image

Is this OK:

fb222f;

image

willeastcott commented 3 months ago

If it is OK, this is simply a matter of changing this:

https://github.com/playcanvas/pcui/blob/f081ef4087caaab2b0a092a2250ab362fec33182/src/components/Label/style.scss#L34

...to use $error instead of $error-secondary.

LeXXik commented 3 months ago

Not sure, they look exactly the same to me :D Can it be lighter?

willeastcott commented 3 months ago

What about this:

image

LeXXik commented 3 months ago

Definitely much better. I can see it clearly.