search

playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
154 stars 28 forks source link

Assets list to show folders first and then files. #178

Open Maksims opened 3 years ago

Maksims commented 3 years ago

In Code Editor folders are shown first, and then files - this is easy to navigate and looks clean. In Editor using list view in assets panel, does not shows folders first, it mixes them with files, leading to messy navigation and difference with Code Editor.

Code Editor (good): image

Editor (not good): image

vkalpias commented 3 years ago

Hi Max - this is because in the list view rows are sorted alphabetically depending on the sorting column. I thought that when you sort by Name (or any other column) it would be confusing to not see a correctly sorted list because Folders would be special. E.g. if you're trying to see all folders that start with 'g' you can now see it by sorting by Name.

Also another reason was that you can sort by Type so if you wanted to see all folders you could sort by Type and see all the folders grouped together?

willeastcott commented 3 years ago

Well, folders are kind of special in Windows Explorer (and will appear before all non-folders in details view). I think the weird thing for me is that we're not being consistent across Code Editor and Editor.

vkalpias commented 3 years ago

Just looking at Mac here it seems that it doesn't differentiate folders in terms of order when ordered alphabetically. The code editor is using the old system, it's not even using PCUI..

Maksims commented 3 years ago

Additionally, after moving to pcui, styling is off, is it something I can make PR to pcui repo and will be incorporated in Editor?

vkalpias commented 3 years ago

You can make PRs in pcui - some styling changes are deliberate though so you might wanna point those out :)

willeastcott commented 3 years ago

Yeah, just to emphasize that @Maksims, PRs are definitely welcome on the pcui repo. But always open an issue first and give @ellthompson and @vkalpias a chance to respond before submitting the PR (and then configure the PR to auto-close the issue on merge). 😄

RipcordDev commented 3 years ago

I would personally like to see folders sorted first, then files listed after like in the code editor. It's the default behaviour in Windows,, which to me makes things more intuitive. I feel like it used to be this way, but maybe my projects were just smaller in the past and I didn't have as many files in them :D

I know you can sort by Type but it resets every time I open the project.