playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
158 stars 28 forks source link

Asset selection by collaborative user color tag is offset. #179

Closed Maksims closed 3 years ago

Maksims commented 4 years ago

When collaborative user is selecting asset, it renders color coded box of that user (useful feature). But if List view is used, it will offset the box to next line, making row higher.

Notice orange box is not after filename, but on next line. image

Fix: render color cube at the end of that name column.

Solution:

Add style to .pcui-asset-panel-users when it is rendered as list:

margin-top: 7px;
float: right;
flex-direction: row;
vkalpias commented 3 years ago

Hi!

I'm not able to reproduce that can you check if this is still happening? And which browser / version / OS you're using?

Thanks

willeastcott commented 3 years ago

Could this be related to browser tab scaling, @Maksims?

Maksims commented 3 years ago

It has been changed since (improved), but still looks wrong (not centered vertically): image

vkalpias commented 3 years ago

That was actually by design to accommodate up to 2 rows of indicators.. It's not great but open to ideas :)

Maksims commented 3 years ago

Row is very wide to accommodate number of dots. Seeing large number of dots is less useful than seeing few specific ones. So having one row, and limit it to (8?) dots, I believe is a reasonable solution.

willeastcott commented 3 years ago

Yeah, sounds reasonable to me.

vkalpias commented 3 years ago

OK this will be fixed in next release.