search

playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
161 stars 28 forks source link

Templates do not hide diffs for UI element fitMode #827

Open LeXXik opened 2 years ago

LeXXik commented 2 years ago

Sometimes templates fail to hide the diffs after applying all changes. The changes are actually applied, but the diffs are still visible:

https://user-images.githubusercontent.com/5677782/178514652-e9bbafb9-8756-4683-8fa0-193fb16e3778.mp4

yaustar commented 2 years ago

We've had another report of this on Slack. Do you have a repro project to share?

LeXXik commented 2 years ago

Its in uber project, let me see if I can repro.

yaustar commented 2 years ago

I tried to repro in a simpler project with little luck

LeXXik commented 2 years ago

https://playcanvas.com/project/956431/overview/template-issue

yaustar commented 2 years ago

Thanks! I can see the issue now and will assign

jpauloruschel commented 2 years ago

First things first, this issue appears to be only in Diff View, with no underlying data loss. Additionally, creating new entities or duplicating those entities does not seem to replicate the issue.

fitMode is a property that was added recently, and it is only shown (and used) if the element has a Texture or Sprite attached (which those entities do not). Were those entities first created some time ago (before fitMode was added)? And also, can you reproduce this issue with new entities?

LeXXik commented 2 years ago

These templates were created a while back. Possibly before the fitMode was introduced. The fitMode is not reproduced with new templates, but the main issue is still there - the UI shows there are differences, when there are not:

https://user-images.githubusercontent.com/5677782/178546013-32bb0a52-0435-4b82-b6f2-5cd628e06b83.mp4

yaustar commented 2 years ago

Raised priority due to the number of reports coming in