search

playcanvas / engine

JavaScript game engine built on WebGL, WebGPU, WebXR and glTF
https://playcanvas.com
MIT License
9.52k stars 1.33k forks source link

License banner gone from release/minified builds since 1.57.0 #5280

Closed willeastcott closed 1 year ago

willeastcott commented 1 year ago

The license banner has been gone from release and minified builds since engine release 1.57.0.

1.56.0: https://code.playcanvas.com/playcanvas-1.56.0.min.js

1.57.0: https://code.playcanvas.com/playcanvas-1.57.0.min.js

It seems to be due to this PR from @slimbuck:

https://github.com/playcanvas/engine/pull/4601

Specifically, this line:

https://github.com/playcanvas/engine/pull/4601/files#diff-6814bf77564b4f1c92f5861e184e28fe217c080a047fefa8b73a728f755ec45cR194

slimbuck commented 1 year ago

I think I removed the banner because all modules got the banner and it bloated the build.

willeastcott commented 1 year ago

I think it should have just been removed from module builds. It was also removed from ES5 builds.

smbraun commented 1 year ago

I would like to see some sort of version indication in the file. We have 10+ different sites running different PlayCanvas Engines. When a breaking change comes out it makes it easier to track down what sites we need to update. Even just having the bare minimum "* v1.55.0 revision 0cab2ed64" would be fine.

mvaligursky commented 1 year ago

we have that @smbraun For example load the latest version from here: https://code.playcanvas.com/playcanvas-1.61.1.js and you can find this inside:

    var version = '1.61.1';
    var revision = 'b6dc0dcf3';
yaustar commented 1 year ago

Another way to get the version is to type pc.version in the dev console of the hosted build. It's what I do to help diagnose users published projects when issues come in