playcanvas / engine

JavaScript game engine built on WebGL, WebGPU, WebXR and glTF
https://playcanvas.com
MIT License
9.7k stars 1.36k forks source link

Shadow Update Mode 'Once' acting different after 1.61.3 #5293

Open defektu opened 1 year ago

defektu commented 1 year ago

About previous issue #5273, VSM shadows seems fixed. Shadow update mode 'Once' fires while models loading I assume.

This issue is happening with VSM shadows.

Also VSM blur seems acting weird / not working.

Screenshots

Editor Screenshot at initialize

image

Editor Screenshot (Shadows updated by clicking Light Mapper UI button)

image

Launch Screenshot 1.62.2

image

Launch Screenshot 1.61.3 (With SS applied. Sorry about that, it's built project.)

image

mvaligursky commented 1 year ago

We've made this further VSM fix to actually apply blur few days ago, but this has been not released yet - which will fix some (all?) of the problems here.

https://github.com/playcanvas/engine/pull/5288

defektu commented 1 year ago

Thanks for reply. Did not see #5286 . Some shadow problem besides blur is present. Will wait for changes to check that. Sphere has that visible bug too.

mvaligursky commented 1 year ago

Would you have any details or repro of this issue? "Sphere has that visible bug too."

defektu commented 1 year ago

Here are the screenshots. VSM blur will possibly fix it but shadows look completely different. (Talking about ear shadow)

Shadow Update Mode is Once in these examples.

1.62.2

image

1.61.3

image

Sphere 1.62.2

image

Sphere 1.61.3

image

yaustar commented 1 year ago

Can you try against https://code.playcanvas.com/playcanvas-latest.min.js which is the main branch of the engine and would include the fix #5286

defektu commented 1 year ago

Tested it. Problem persists still. The project you provided in #5286 has same bug too.

yaustar commented 1 year ago

I've created a new project to try to showcase this:

https://playcanvas.com/project/1071416/overview/vsm-bug-162-shadow-once

1.61.3: https://launch.playcanvas.com/1737145?use_local_engine=https://code.playcanvas.com/playcanvas-1.61.3.js

image

1.63.0: https://launch.playcanvas.com/1737145?use_local_engine=https://code.playcanvas.com/playcanvas-1.63.0.js

image

Noticed the shadow around the ball is different

This only occurs if the shadow is set to 'Once'. 'Realtime' looks the same on both engine versions