search

playcanvas / engine

JavaScript game engine built on WebGL, WebGPU, WebXR and glTF
https://playcanvas.com
MIT License
9.52k stars 1.33k forks source link

Particle system broken on Samsung Galaxy note 10+ #5342

Closed baghban71 closed 1 year ago

baghban71 commented 1 year ago

This workaround don't work on Samsung Galaxy note 10+ (android 12)

https://github.com/playcanvas/engine/pull/4147

supportsGpuParticles flag return true on that device

photo_2023-05-21_14-27-27

yaustar commented 1 year ago

I reverted that workaround in this PR https://github.com/playcanvas/engine/pull/5255 as I couldn't reproduce the issue any more on most Samsung Exynos devices during testing with the original test projects.

Can you provide an example project of the issue you are seeing for the team to test against please?

yaustar commented 1 year ago

I wonder if the Mali-G76 is also an affected GPU that either I didn't have access to at time or missed 🤔

baghban71 commented 1 year ago

This example and any project that contain particle have similar issue on that device : https://playcanvas.github.io/#/graphics/particles-spark

also my older project : https://doondook.studio/games/dd-line-ball/v1.0.0/

yaustar commented 1 year ago

@mvaligursky, I can't test against those devices any more. Could you check against Mali-G76 and see if it's specific against that GPU or we can re-add the Samsung Exynos model check again as a catch all.

mvaligursky commented 1 year ago

I'd say we add the catch all again.