playcanvas / engine

JavaScript game engine built on WebGL, WebGPU, WebXR and glTF
https://playcanvas.com
MIT License
9.55k stars 1.34k forks source link

Anti Aliasing is suddenly deactivated #5727

Closed kungfooman closed 11 months ago

kungfooman commented 11 months ago

Example before/after:

image

Last PR I could find is: https://github.com/playcanvas/engine/pull/5679

Is this expected behaviour?

mvaligursky commented 11 months ago

I'm not sure I can confirm. I loaded https://playcanvas.github.io/#/misc/hello-world

Then add this line to render into low resolution and make it visible:

Screenshot 2023-10-06 at 15 09 43

and then toggle antialias this way:

Screenshot 2023-10-06 at 15 10 42

and that seems to work ok with expected difference between true and false. Same in the blend-trees-1d example.

kungfooman commented 11 months ago

@mvaligursky Thank you for testing, I just figured it only happens when running the Examples Browser via npm run serve for me... very strange, not sure what causes the difference yet :mag:

I can't even force it via gfxOptions.antialias = true in npm run serve mode

kungfooman commented 11 months ago

Okay, I had npm run serve running in WebGL1 mode and because of Port 80 vs 5000 it was using different localStorage sessions... :see_no_evil: