playcanvas / engine

Powerful web graphics runtime built on WebGL, WebGPU, WebXR and glTF
https://playcanvas.com
MIT License
9.73k stars 1.36k forks source link

Gaussian splats not pickable #6974

Open MAG-AdrianMeredith opened 2 months ago

MAG-AdrianMeredith commented 2 months ago

In gsplat-compressed-material.js there is the following code:

        #ifdef PICK_PASS
            if (B < 0.3) {
                discard;
            }
            return uColor;
        #endif

Where its expecting the colour picker color as uColor however this is no longer how the picker works and instead the color is derived from the mesh_instance_id parameter from

getPickOutput()

Steps to Reproduce

  1. add a gaussian splat
  2. attempt to pick it
  3. the pick colour is rendered black and no selection picked
MAG-AdrianMeredith commented 2 months ago

Interesting theres no equivalent in gsplat-material.js.

mvaligursky commented 2 months ago

yep definitely something we need to fix.