Closed marklundin closed 6 days ago
The engine is marked as not having sideEffects, however deprecated.js contains numerous side effects.
This has important consequences, as most bundlers will tree-shake/remove deprecated.js in a production build, meaning code can behave differently in production. You can see a repro here https://stackblitz.com/edit/vitejs-vite-t6vvne?file=main.js,vite.config.js,index.html
deprecated.js
This PR marks deprecated.js as a sideEffect which is a common indicator to most bundlers not to tree-shake that file.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.
The engine is marked as not having sideEffects, however deprecated.js contains numerous side effects.
This has important consequences, as most bundlers will tree-shake/remove
deprecated.jsin a production build, meaning code can behave differently in production. You can see a repro here https://stackblitz.com/edit/vitejs-vite-t6vvne?file=main.js,vite.config.js,index.htmlThis PR marks
deprecated.jsas a sideEffect which is a common indicator to most bundlers not to tree-shake that file.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.