search

playcanvas / pcui-graph

A PCUI extension for creating node-based graphs
https://playcanvas.github.io/pcui-graph
MIT License
121 stars 14 forks source link

PCUI-Graph styles embed PCUI styles #45

Closed willeastcott closed 1 year ago

willeastcott commented 1 year ago

See here:

https://github.com/playcanvas/pcui-graph/blob/07d647a6f18156e8aa112bcdeeb52559e8c843d7/src/styles/style.scss#L4

This feels wrong to me. Shouldn't the application import PCUI and then import PCUI-Graph styles? Some problems:

  1. Currently, the PlayCanvas Editor has two copies of PCUI styles in the compiled CSS.
  2. This forces a user that's using PCUI-Graph to use the PCUI green theme.
willeastcott commented 1 year ago

Observation: