search

playcanvas / playcanvas-spine

Plugin component for PlayCanvas which enables support for Spine animations.
MIT License
48 stars 18 forks source link

Minor Issue: Mesh constructor takes a GraphicsDevice as a parameter #70

Closed epreston closed 1 year ago

epreston commented 1 year ago

Description

Engine Build: 1.6.5

Deprecation warning:

DEPRECATED: Mesh constructor takes a GraphicsDevice as a parameter, and it was not provided.

From the following line:

https://github.com/playcanvas/playcanvas-spine/blob/71ec3c5d9a534cf05e6b5a20db6aa55198aad842/src/spine.js#L543C38-L543C38

Resolution

Should be changed to the following or similar:

var mesh = new pc.Mesh(pc.graphicsDevice);

Deprecated 10 months ago.

willeastcott commented 1 year ago

I think it'd be:

var mesh = new pc.Mesh(this._app.graphicsDevice);
epreston commented 1 year ago

Will clarified the timeline for the Mesh constructor signature change here: https://github.com/playcanvas/playcanvas-spine/pull/73#discussion_r1287148079

It's been 3 years since 1.27

epreston commented 1 year ago

Remediation plan here: https://github.com/playcanvas/playcanvas-spine/pull/73#discussion_r1285579429