search

playcanvas / playcanvas-tween

A tween library for PlayCanvas
MIT License
59 stars 46 forks source link

Two small issues (EASE_LINEAR and var tmp) #14

Closed kungfooman closed 5 years ago

kungfooman commented 5 years ago

Just converted this to TypeScript for testing and it found two issues:

https://github.com/playcanvas/playcanvas-tween/blob/5ffeebd56d56f611e5c60b5dfb920eb903930aed/tween.js#L84

This is not defined, it probably should be pc.Linear

https://github.com/playcanvas/playcanvas-tween/blob/5ffeebd56d56f611e5c60b5dfb920eb903930aed/tween.js#L430

tmp is leaking into global/window context