player-ui / player

https://player-ui.github.io
MIT License
73 stars 47 forks source link

revert async node flatten #512

Closed cehan-Chloe closed 2 months ago

cehan-Chloe commented 2 months ago
  1. Revert flatten nested node change
  2. update tests for all platforms

Change Type (required)

Indicate the type of change your pull request is:

Does your PR have any documentation updates?

brocollie08 commented 2 months ago

might need to change test on other platforms too

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.84%. Comparing base (12b4867) to head (870606d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #512 +/- ## ========================================== + Coverage 91.88% 92.84% +0.95% ========================================== Files 341 341 Lines 27237 27232 -5 Branches 1945 1944 -1 ========================================== + Hits 25028 25284 +256 + Misses 2195 1948 -247 + Partials 14 0 -14 ``` | [Flag](https://app.codecov.io/gh/player-ui/player/pull/512/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=player-ui) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/player-ui/player/pull/512/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=player-ui) | `92.84% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=player-ui#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.