player-ui / player

https://player-ui.github.io
MIT License
73 stars 47 forks source link

ios: enhance tapable logger to handle variadic args from the JS log #524

Closed nancywu1 closed 1 month ago

nancywu1 commented 1 month ago

https://github.com/player-ui/player/issues/523

Change Type (required)

Indicate the type of change your pull request is:

Does your PR have any documentation updates?

nancywu1 commented 1 month ago

/canary

nancywu1 commented 1 month ago

/canary

nancywu1 commented 1 month ago

/canary

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 99.04762% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (a363556) to head (2633358). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ios/logger/Sources/TapableLogger.swift 97.67% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #524 +/- ## ========================================== + Coverage 91.91% 91.92% +0.01% ========================================== Files 341 341 Lines 27311 27290 -21 Branches 1944 1944 ========================================== - Hits 25103 25087 -16 + Misses 2194 2189 -5 Partials 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.