codecov[bot]
commented
2 days ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.51%. Comparing base (
05f718f) to head (69ab40a). Report is 1 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #552 +/- ## ======================================= Coverage 89.51% 89.51% ======================================= Files 331 331 Lines 19837 19837 Branches 1949 1949 ======================================= Hits 17757 17757 Misses 2066 2066 Partials 14 14 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
brocollie08
This PR makes available a JVM ConsoleLoggerPlugin that can be added to any supported JS runtime in for the JVM, forwarding all console logs to a provided logger
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
📦 Published PR as canary version:
0.9.2--canary.552.18572Try this version out locally by upgrading relevant packages to 0.9.2--canary.552.18572
Version
Published prerelease version:
0.10.0-next.8Changelog
### Release Notes #### Add Missing DSL Docs ([#548](https://github.com/player-ui/player/pull/548)) Docs - Add DSL docs #### Applicability docs ([#544](https://github.com/player-ui/player/pull/544)) - Update applicability docs to reflect desired patterns and behaviors - Fix flaky react reference asset test - Fix misc vitest issues when running outside of bazel (cjs environment, excluded directories) ### Change Type (required) Indicate the type of change your pull request is: - [x] `patch` - [ ] `minor` - [ ] `major` ### Does your PR have any documentation updates? - [x] Updated docs - [ ] No Update needed - [ ] Unable to update docs #### Remove unneeded dependency on `pubsub-js` ([#547](https://github.com/player-ui/player/pull/547)) Remove dead dependencies ### Change Type (required) Indicate the type of change your pull request is: - [ ] `patch` - [ ] `minor` - [ ] `major` ### Does your PR have any documentation updates? - [ ] Updated docs - [ ] No Update needed - [ ] Unable to update docs #### Minor Docs Fixes ([#538](https://github.com/player-ui/player/pull/538)) - Fix search on `next` subdomain searching against and redirecting to `latest` - Update page description on the landing page ### Change Type (required) Indicate the type of change your pull request is: - [ ] `patch` - [ ] `minor` - [ ] `major` ### Does your PR have any documentation updates? - [x] Updated docs - [ ] No Update needed - [ ] Unable to update docs #### More Doc Fixes ([#532](https://github.com/player-ui/player/pull/532)) - Fix links for `latest` and `next` pages - Add package manager tabs for js install instructions - Fix version selector breaking on main page ### Change Type (required) Indicate the type of change your pull request is: - [x] `patch` - [ ] `minor` - [ ] `major` ### Does your PR have any documentation updates? - [ ] Updated docs - [ ] No Update needed - [ ] Unable to update docs #### Fix docs build visibility ([#531](https://github.com/player-ui/player/pull/531)) Fix visibility of docs build #### ios: enhance tapable logger to handle variadic args from the JS log ([#524](https://github.com/player-ui/player/pull/524)) Prefixing message with the format `[Player] [\(logLevel)]:` moved out of the Tapable logger and moved to PrintLoggerPlugin. Any consumers using their own LoggerPlugin will need to append the logLevel if they want to print it Before ```swift public class CustomLoggingPlugin: NativePlugin { public let pluginName = "CustomLoggingPlugin" public func apply(player: P) where P: HeadlessPlayer { guard let player = player as? SwiftUIPlayer else { return } player.logger.logLevel = .trace player.logger.hooks.trace.tap(name: pluginName, { print("Custom message")\(($0))" ) }) ... } ``` After ```swift public class CustomLoggingPlugin: NativePlugin { public let pluginName = "CustomLoggingPlugin" public func apply
(player: P) where P: HeadlessPlayer { guard let player = player as? SwiftUIPlayer else { return } player.logger.logLevel = .trace let prefixedMessage = "[Player] [trace]: " player.logger.hooks.trace.tap(name: pluginName, { print("\(prefixedMessage) Custom message \(($0))" ) }) ... } ``` ## Breaking Changes Any usage of the `player.logger.hooks` taps will have breaking changes in the callback because the calls have been changed to provide a `[Any]` type instead of `String` so it can be returned in the form of messages instead of a single message. Unless nothing is done in the callback to access the value but just to print it, there should be breaking changes Example: ```swift // this should be no breaking change player.logger.hooks.trace.tap(name: "log", { print("\(($0))" ) }) // if `values` should be accessed in anyway, i.e want the first value, or want to seperate the values player.logger.hooks.debug.tap(name: "log") { values in // values is of type [Any], if you want to print only the first value print("\((message as? [String])?.first))" ) } ``` --- #### 🚀 Enhancement - ios: enhance tapable logger to handle variadic args from the JS log [#524](https://github.com/player-ui/player/pull/524) ([@nancywu1](https://github.com/nancywu1)) #### 🐛 Bug Fix - JVM ConsoleLoggerPlugin [#552](https://github.com/player-ui/player/pull/552) ([@brocollie08](https://github.com/brocollie08)) - Applicability docs [#544](https://github.com/player-ui/player/pull/544) ([@KetanReddy](https://github.com/KetanReddy) [@nancywu1](https://github.com/nancywu1)) - iOS: Expose builldBeacon and cancelBeacon hooks inside of BaseBeaconPlugin and make BeaconPlugin open class [#536](https://github.com/player-ui/player/pull/536) ([@sakuntala-motukuri](https://github.com/sakuntala-motukuri)) - Remove unneeded dependency on `pubsub-js` [#547](https://github.com/player-ui/player/pull/547) ([@KetanReddy](https://github.com/KetanReddy)) - remove unneeded HTML report generation steps from build [#545](https://github.com/player-ui/player/pull/545) ([@nancywu1](https://github.com/nancywu1)) - Fix parsing of Bindings with Escaped Numbers [#533](https://github.com/player-ui/player/pull/533) ([@KetanReddy](https://github.com/KetanReddy)) - Update getting-started.mdx [#534](https://github.com/player-ui/player/pull/534) ([@aarora-pm](https://github.com/aarora-pm)) - More Doc Fixes [#532](https://github.com/player-ui/player/pull/532) ([@KetanReddy](https://github.com/KetanReddy)) - Fix docs build visibility [#531](https://github.com/player-ui/player/pull/531) ([@KetanReddy](https://github.com/KetanReddy)) - Fix CJS support for React Player [#525](https://github.com/player-ui/player/pull/525) ([@KetanReddy](https://github.com/KetanReddy)) - iOS: Expand AnyType to handle deeply nested AnyType for beacon encoding [#519](https://github.com/player-ui/player/pull/519) ([@hborawski](https://github.com/hborawski)) - Updating Main Page Content [#508](https://github.com/player-ui/player/pull/508) ([@KetanReddy](https://github.com/KetanReddy) [@adierkens](https://github.com/adierkens)) #### 🏠 Internal - Fix circleci badge in README [#480](https://github.com/player-ui/player/pull/480) ([@adierkens](https://github.com/adierkens) [@KetanReddy](https://github.com/KetanReddy)) #### 📝 Documentation - Add Missing DSL Docs [#548](https://github.com/player-ui/player/pull/548) ([@KetanReddy](https://github.com/KetanReddy)) - improve prominence of bazel build guidance for iOS targets [#546](https://github.com/player-ui/player/pull/546) ([@hborawski](https://github.com/hborawski)) - Minor Docs Fixes [#538](https://github.com/player-ui/player/pull/538) ([@KetanReddy](https://github.com/KetanReddy)) - fix exports in docs [#511](https://github.com/player-ui/player/pull/511) ([@spentacular](https://github.com/spentacular) [@KetanReddy](https://github.com/KetanReddy)) - Docs refresh with Astro [#506](https://github.com/player-ui/player/pull/506) ([@adierkens](https://github.com/adierkens) [@KetanReddy](https://github.com/KetanReddy)) #### Authors: 8 - [@aarora-pm](https://github.com/aarora-pm) - [@brocollie08](https://github.com/brocollie08) - [@nancywu1](https://github.com/nancywu1) - Adam Dierkens ([@adierkens](https://github.com/adierkens)) - Harris Borawski ([@hborawski](https://github.com/hborawski)) - Ketan Reddy ([@KetanReddy](https://github.com/KetanReddy)) - Niharika Motukuri ([@sakuntala-motukuri](https://github.com/sakuntala-motukuri)) - Spencer Hamm ([@spentacular](https://github.com/spentacular))