codecov[bot]
commented
4 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.05%. Comparing base (
bb0fb5d) to head (2d89274).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #146 +/- ## ======================================= Coverage 73.05% 73.05% ======================================= Files 87 87 Lines 12946 12946 Branches 1216 1217 +1 ======================================= Hits 9458 9458 Misses 3469 3469 Partials 19 19 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
KetanReddy
Currently, the CLI assumes that any result from the compilation hook is an object that can be serialized to JSON and should be written to a file that ends in
.js. There are potentially other usecases for compiling Player related content that may not result in a JSON serializable result. This PR expands the results to generalize what the compilation is to be some string that should be written as the output file, and an optional second string that should be written as the source map.Change Type (required)
Indicate the type of change your pull request is:
patchminormajorRelease Notes
Allow DSL compilation phase to compile to non
.jsontargets📦 Published PR as canary version:
0.7.0--canary.146.3413Try this version out locally by upgrading relevant packages to 0.7.0--canary.146.3413
Version
Published prerelease version:
0.7.0-next.7Changelog
### Release Notes #### Update CLI to Allow Compilation to any File Type ([#146](https://github.com/player-ui/tools/pull/146)) Allow DSL compilation phase to compile to non `.json` targets #### Fix Issue Validating Templates ([#125](https://github.com/player-ui/tools/pull/125)) XLR - Fully resolve references, intersection types, conditional types, and generic types when returning a type JSON Language Server - Add generic tokens when constructing template types in transform Validation - Fix issue validating nested arrays in templates. #### #132 - Adds a dev tools web plugin generator ([#133](https://github.com/player-ui/tools/pull/133)) Adds a generator to facilitate adding new dev tools web plugins: ```bash pnpm gen:dev-tools-web-plugin ``` #### Fix Bug when Validating `null` literals ([#123](https://github.com/player-ui/tools/pull/123)) Validator - Properly validate `NullType` nodes against `null` literals #### Fix Parsing Indexed Access Types with Parentheses ([#112](https://github.com/player-ui/tools/pull/112)) XLR - Fixed compilation of `IndexedAccesNodes `that use parentheses around the first element. #### Fix Regression on Validation of Keys with Escaped Characters ([#110](https://github.com/player-ui/tools/pull/110)) XLR - Fixes validation of objects where a property is escaped using single/double quotes and the property is required or the object doesn't allow additional properties. --- #### 🚀 Enhancement - Update CLI to Allow Compilation to any File Type [#146](https://github.com/player-ui/tools/pull/146) ([@KetanReddy](https://github.com/KetanReddy)) - #132 - Adds a dev tools web plugin generator [#133](https://github.com/player-ui/tools/pull/133) ([@rafbcampos](https://github.com/rafbcampos)) - Dev tools profiler plugin [#114](https://github.com/player-ui/tools/pull/114) ([@rafbcampos](https://github.com/rafbcampos)) #### 🐛 Bug Fix - revert canary on forks [#147](https://github.com/player-ui/tools/pull/147) ([@mercillo](https://github.com/mercillo)) - trigger forked PR canary in correct format for CircleCI [#145](https://github.com/player-ui/tools/pull/145) ([@hborawski](https://github.com/hborawski)) - Fix Canary workflow for forks [#144](https://github.com/player-ui/tools/pull/144) ([@hborawski](https://github.com/hborawski)) - [circleCI] allows us to build from forks [#135](https://github.com/player-ui/tools/pull/135) ([@mercillo](https://github.com/mercillo)) - [bazel - npm registry] flipper-plugin-player-ui-devtools [#138](https://github.com/player-ui/tools/pull/138) ([@lexfm](https://github.com/lexfm)) - Fix Issue Validating Templates [#125](https://github.com/player-ui/tools/pull/125) ([@KetanReddy](https://github.com/KetanReddy)) - [Devtools]FlowPanel/ObjectInspector/PathFilter [#131](https://github.com/player-ui/tools/pull/131) ([@lexfm](https://github.com/lexfm)) - chore: add branch check to CI and bump locks [#124](https://github.com/player-ui/tools/pull/124) ([@rafbcampos](https://github.com/rafbcampos)) - Fix Bug when Validating `null` literals [#123](https://github.com/player-ui/tools/pull/123) ([@KetanReddy](https://github.com/KetanReddy)) - Devtools- panel layout fix and version upgrade [#122](https://github.com/player-ui/tools/pull/122) ([@mercillo](https://github.com/mercillo)) - Use Slim Bazel Image [#119](https://github.com/player-ui/tools/pull/119) ([@KetanReddy](https://github.com/KetanReddy)) - Added additional DSL types and component [#118](https://github.com/player-ui/tools/pull/118) ([@mrigankmg](https://github.com/mrigankmg)) - Devtools/default selected player [#117](https://github.com/player-ui/tools/pull/117) ([@mercillo](https://github.com/mercillo)) - Fix Parsing Indexed Access Types with Parentheses [#112](https://github.com/player-ui/tools/pull/112) ([@KetanReddy](https://github.com/KetanReddy)) - Fix Regression on Validation of Keys with Escaped Characters [#110](https://github.com/player-ui/tools/pull/110) ([@KetanReddy](https://github.com/KetanReddy)) #### 📝 Documentation - Docs/devtools - local development for extension [#105](https://github.com/player-ui/tools/pull/105) (marlon_ercillo@intuit.com [@mercillo](https://github.com/mercillo)) #### Authors: 7 - Alex Fimbres ([@lexfm](https://github.com/lexfm)) - Harris Borawski ([@hborawski](https://github.com/hborawski)) - Ketan Reddy ([@KetanReddy](https://github.com/KetanReddy)) - marky ercillo (marlon_ercillo@intuit.com) - Marlon "Marky" Ercillo ([@mercillo](https://github.com/mercillo)) - Mrigank Mehta ([@mrigankmg](https://github.com/mrigankmg)) - Rafael Campos ([@rafbcampos](https://github.com/rafbcampos))