search

player-ui / tools

A Place for tooling related to Player
MIT License
9 stars 12 forks source link

Fix object null in deeply nested obejcts - devtools #158

Closed mercillo closed 3 months ago

mercillo commented 3 months ago

dset had issues when encountering null in objects. This caused some issues with devtools not rendering the page correctly.

https://github.com/lukeed/dset/issues/36

Change Type (required)

Indicate the type of change your pull request is:

Version

Published prerelease version: 0.7.1-next.2

Changelog ### Release Notes #### Fix Source Maps not Being Generated for DSL Content ([#155](https://github.com/player-ui/tools/pull/155)) Fix source maps not being generated for DSL content when compiled by the cli #### Update Dependencies ([#151](https://github.com/player-ui/tools/pull/151)) - Use Node 20 - Use TypeScript 5.5 --- #### 🐛 Bug Fix - Fix object null in deeply nested obejcts - devtools [#158](https://github.com/player-ui/tools/pull/158) ([@mercillo](https://github.com/mercillo)) - Fix Source Maps not Being Generated for DSL Content [#155](https://github.com/player-ui/tools/pull/155) ([@KetanReddy](https://github.com/KetanReddy)) - Update Dependencies [#151](https://github.com/player-ui/tools/pull/151) ([@KetanReddy](https://github.com/KetanReddy)) - Re-add compiler formatting to dsl output [#153](https://github.com/player-ui/tools/pull/153) ([@sugarmanz](https://github.com/sugarmanz)) #### Authors: 3 - Jeremiah Zucker ([@sugarmanz](https://github.com/sugarmanz)) - Ketan Reddy ([@KetanReddy](https://github.com/KetanReddy)) - Marlon "Marky" Ercillo ([@mercillo](https://github.com/mercillo))
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 45.16129% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (98f68e0) to head (9e8ab1c). Report is 8 commits behind head on main.

Files Patch % Lines
.../plugins/desktop/profiler/src/WrapperComponent.tsx 0.00% 9 Missing :warning:
...ols/plugins/desktop/basic/src/WrapperComponent.tsx 0.00% 6 Missing :warning:
devtools/plugins/desktop/basic/src/index.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #158 +/- ## ======================================= Coverage 73.05% 73.06% ======================================= Files 87 87 Lines 12946 12945 -1 Branches 1216 1217 +1 ======================================= Hits 9458 9458 + Misses 3469 3468 -1 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.