search

player-ui / tools

A Place for tooling related to Player
MIT License
9 stars 12 forks source link

feat: highlight current player instance #160

Closed cehan-Chloe closed 2 months ago

cehan-Chloe commented 3 months ago

Add highlight for current instance

https://github.com/user-attachments/assets/80ae052c-be84-4690-9971-bbf2f6cf0145

Note:

  1. add id (playid) as optional param for each player instance. As devtools-basic-web-plugin was used in tto-webplayer, use default-id when no id passed in

  2. revert commit for updating pnpm as it breaks the devtool with error TypeError: Cannot read properties of null (reading 'useReducer')

Change Type (required)

Indicate the type of change your pull request is:

Release Notes

When we have multiple Player instances on the same page, highlight current selected player instance

Version

Published prerelease version: 0.8.0-next.1

Changelog ### Release Notes #### Update Rules Versions ([#163](https://github.com/player-ui/tools/pull/163)) Update JS Rules to latest Aspect major - [x] `patch` - [ ] `minor` - [ ] `major` #### Fix Source Maps not Being Generated for DSL Content ([#155](https://github.com/player-ui/tools/pull/155)) Fix source maps not being generated for DSL content when compiled by the cli #### Update Dependencies ([#151](https://github.com/player-ui/tools/pull/151)) - Use Node 20 - Use TypeScript 5.5 --- #### 🚀 Enhancement - feat: doesn't exit with error if warn-only on dsl validation [#159](https://github.com/player-ui/tools/pull/159) ([@rafbcampos](https://github.com/rafbcampos)) #### 🐛 Bug Fix - feat: highlight current player instance [#160](https://github.com/player-ui/tools/pull/160) ([@cehan-Chloe](https://github.com/cehan-Chloe) [@rafbcampos](https://github.com/rafbcampos)) - Update Rules Versions [#163](https://github.com/player-ui/tools/pull/163) ([@KetanReddy](https://github.com/KetanReddy)) - Fix object null in deeply nested obejcts - devtools [#158](https://github.com/player-ui/tools/pull/158) ([@mercillo](https://github.com/mercillo)) - Fix Source Maps not Being Generated for DSL Content [#155](https://github.com/player-ui/tools/pull/155) ([@KetanReddy](https://github.com/KetanReddy)) - Update Dependencies [#151](https://github.com/player-ui/tools/pull/151) ([@KetanReddy](https://github.com/KetanReddy)) - Re-add compiler formatting to dsl output [#153](https://github.com/player-ui/tools/pull/153) ([@sugarmanz](https://github.com/sugarmanz)) #### Authors: 5 - Chloeeeeeee ([@cehan-Chloe](https://github.com/cehan-Chloe)) - Jeremiah Zucker ([@sugarmanz](https://github.com/sugarmanz)) - Ketan Reddy ([@KetanReddy](https://github.com/KetanReddy)) - Marlon "Marky" Ercillo ([@mercillo](https://github.com/mercillo)) - Rafael Campos ([@rafbcampos](https://github.com/rafbcampos))
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 47.36842% with 120 lines in your changes missing coverage. Please review.

Project coverage is 72.77%. Comparing base (b45f3ae) to head (a8dd8bf). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ols/plugins/desktop/basic/src/WrapperComponent.tsx 0.00% 54 Missing :warning:
devtools/messenger/src/index.ts 70.89% 38 Missing and 1 partial :warning:
devtools/client/src/state/index.ts 0.00% 9 Missing :warning:
devtools/plugins/desktop/basic/src/index.tsx 0.00% 7 Missing :warning:
...plugins/desktop/common/src/state/usePluginState.ts 0.00% 7 Missing :warning:
.../plugins/desktop/profiler/src/WrapperComponent.tsx 0.00% 2 Missing :warning:
...tools/plugins/desktop/basic/src/constants/index.ts 0.00% 1 Missing :warning:
...vtools/plugins/desktop/common/src/state/reducer.ts 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #160 +/- ## ========================================== - Coverage 73.06% 72.77% -0.29% ========================================== Files 87 87 Lines 12945 13033 +88 Branches 1216 1225 +9 ========================================== + Hits 9458 9485 +27 - Misses 3468 3528 +60 - Partials 19 20 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hborawski commented 2 months ago

the Player menu in the video seems to flicker between options before settling after selecting a Player instance, do we need to debounce the update there?

cehan-Chloe commented 2 months ago

the Player menu in the video seems to flicker between options before settling after selecting a Player instance, do we need to debounce the update there?

sorry this is not the up-to-date recording. updated