player-ui / tools

A Place for tooling related to Player
MIT License
9 stars 12 forks source link

Preserve Order of Templates in Slots #177

Closed KetanReddy closed 4 days ago

KetanReddy commented 1 week ago

Release Notes

Fix an issue where Template components in slots that contained a static element wouldn't be serialized to JSON in the same order they were authored in.

Change Type (required)

Indicate the type of change your pull request is:

Version

Published prerelease version: 0.9.0-next.4

Changelog ### Release Notes #### Preserve Order of Templates in Slots ([#177](https://github.com/player-ui/tools/pull/177)) Fix an issue where Template components in slots that contained a static element wouldn't be serialized to JSON in the same order they were authored in. ### Change Type (required) Indicate the type of change your pull request is: - [x] `patch` - [ ] `minor` - [ ] `major` #### Remove Unneeded Dependency ([#178](https://github.com/player-ui/tools/pull/178)) - Remove unneeded dependency `@oclif/plugin-legacy` - Fix issue with how the DSL compilation command passed arguments to the JSON validation plugin ### Change Type (required) Indicate the type of change your pull request is: - [x] `patch` - [ ] `minor` - [ ] `major` #### Add options to LSPAssetsPlugin to load from TSManifest via module import ([#171](https://github.com/player-ui/tools/pull/171)) Allow for loading XLRs to LSP via module imports. Add explicit (optional for now) toggle for distinguishing between module and manifest loading. --- #### 🚀 Enhancement - Multiple devtools plugin fix [#174](https://github.com/player-ui/tools/pull/174) ([@mercillo](https://github.com/mercillo)) #### 🐛 Bug Fix - Preserve Order of Templates in Slots [#177](https://github.com/player-ui/tools/pull/177) ([@KetanReddy](https://github.com/KetanReddy)) - Remove Unneeded Dependency [#178](https://github.com/player-ui/tools/pull/178) ([@KetanReddy](https://github.com/KetanReddy)) - feat: complexity checker plugin [#169](https://github.com/player-ui/tools/pull/169) ([@KetanReddy](https://github.com/KetanReddy) [@kharrop](https://github.com/kharrop) [@cehan-Chloe](https://github.com/cehan-Chloe) [@rafbcampos](https://github.com/rafbcampos) [@intuit-svc](https://github.com/intuit-svc) [@mercillo](https://github.com/mercillo)) - Add options to LSPAssetsPlugin to load from TSManifest via module import [#171](https://github.com/player-ui/tools/pull/171) ([@KetanReddy](https://github.com/KetanReddy)) #### Authors: 6 - [@intuit-svc](https://github.com/intuit-svc) - Chloeeeeeee ([@cehan-Chloe](https://github.com/cehan-Chloe)) - Kelly Harrop ([@kharrop](https://github.com/kharrop)) - Ketan Reddy ([@KetanReddy](https://github.com/KetanReddy)) - Marlon "Marky" Ercillo ([@mercillo](https://github.com/mercillo)) - Rafael Campos ([@rafbcampos](https://github.com/rafbcampos))
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.31%. Comparing base (9af842c) to head (834107c). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
language/dsl/src/template.tsx 97.14% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #177 +/- ## ========================================== + Coverage 73.25% 73.31% +0.05% ========================================== Files 85 85 Lines 12876 12908 +32 Branches 1201 1210 +9 ========================================== + Hits 9432 9463 +31 - Misses 3423 3424 +1 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: