search

playerproject / player

The Player cross-platform robot device interface & server
GNU General Public License v2.0
58 stars 31 forks source link

Fix Python version determination in python bindings #12

Closed morxa closed 5 years ago

morxa commented 5 years ago

Instead of parsing the Python version string manually (which fails with cmake 3.12.1), use the Python version provided by FindPythonInterp.

Also make sure that we first search for the PythonInterp and then for the PythonLibs to guarantee that they use the same Python versions, as suggested by the cmake manual.

morxa commented 5 years ago

Note that FindPythonInterp and FindPythonLibs is also deprecated in cmake 3.12. I thought about submitting a patch that switches to the new FindPython, but that's not compatible with older systems.

morxa commented 5 years ago

What's the status here? Are there any blockers?

richmattes commented 5 years ago

Nope sorry, it just fell off of my radar. Thanks for the patch!

morxa commented 5 years ago

Thank you for merging!