search

playfire / django-debug-toolbar-user-panel

Panel for the Django Debug toolbar to quickly switch between users
http://code.playfire.com/django-debug-toolbar-user-panel/
BSD 3-Clause "New" or "Revised" License
81 stars 31 forks source link

Add new debug constant, so that users can use the toolbar in production ... #11

Closed dstegelman closed 12 years ago

dstegelman commented 12 years ago

Adding this new setting allows for users to set their own preference for using the toolbar when DEBUG = False without having to set DEBUG to True.

lamby commented 12 years ago

First, please just provide a single working commit, not two commits where one fixes the other..

Secondly, there is no need to edit django.conf.settings dynamically; that's actually pretty unreliable and causes weird side-effects - why not add a local app_settings.py?

dstegelman commented 12 years ago

Okay, would a getattr be acceptable for the settings:

getattr(settings, 'DEBUG_TOOLBAR_USER_DEBUG', False)
lamby commented 12 years ago

yes

dstegelman commented 12 years ago

Sorry, I'm just going to make a new pull request.