playframework / play-doc

Play documentation rendering support
Apache License 2.0
21 stars 23 forks source link

Drop interplay #206

Closed ihostage closed 11 months ago

ihostage commented 12 months ago

As part of https://github.com/playframework/interplay/issues/150 Publishing works fine https://github.com/playframework/play-doc/actions/runs/6188115108/job/16799415447

mkurz commented 11 months ago

Please see my last commit I added: You forgot the developers settings. Without having developers present in the pom file sonatype does not allow us to publish release artifacts. For snapshot it is not so strict and works without developers set.

Basically the things that are missing are from the PlayBuildBase sbt plugin . It gets loaded automatically, see https://github.com/playframework/interplay/blob/ad1bddb900e2883f7ad78e59c70fc86603903a52/src/main/scala/interplay/PlayBuildBase.scala#L13 and applies a couple of settings and javac/scalac flags:

I now copied over the developers and the missing javac and scalac flags (I am not saying all of them make sense, I just keep them for now). I did not copy over the resolver settings since it's not necessary.

mkurz commented 11 months ago

See #211