search

playframework / play-ebean

Play Ebean module
Apache License 2.0
102 stars 69 forks source link

Introduce configuration parameter to control the generation of the evolution SQL files #433

Closed ghost closed 8 months ago

ghost commented 9 months ago

Closes #366

ghost commented 8 months ago

I see the pipeline failing with this error: abstract method generateEvolutionsScripts()java.lang.Boolean in interface play.db.ebean.EbeanConfig is present only in current, but the EbeanConfig needs to have that new value, right?

mkurz commented 8 months ago

I see the pipeline failing with this error: abstract method generateEvolutionsScripts()java.lang.Boolean in interface play.db.ebean.EbeanConfig is present only in current, but the EbeanConfig needs to have that new value, right?

Yeah that's because EbeanConfig is an interface and MiMa complains that now all subclasses need to define that method. We can't really work around that.

I pushed a commit to use a primitive boolean instead of the wrapper. Will release 8.1.0 in a minute. Thanks!

mkurz commented 8 months ago

@Mergifyio backport 7.0.x

mergify[bot] commented 8 months ago

backport 7.0.x

✅ Backports have been created

* [#436 [7.0.x] Introduce configuration parameter to control the generation of the evolution SQL files (backport #433) by @vadimvera](https://github.com/playframework/play-ebean/pull/436) has been created for branch `7.0.x`
ihostage commented 8 months ago

Yeah that's because EbeanConfig is an interface and MiMa complains that now all subclasses need to define that method. We can't really work around that.

Does default method not help? It doesn't matter for this, I think. But It's just interesting what behaviour MiMa with adding default method in interface. 🤔