search

playframework / play-grpc

Play + Pekko gRPC
Apache License 2.0
35 stars 29 forks source link

Transfer issues from akka-grpc #35

Closed ignasi35 closed 4 years ago

ignasi35 commented 5 years ago

There's a bunch of play-related issues in akka-grpc we should transfer here.

Unfortunately the repos belong to different organizations to GitHub's transfer issue (beta) doesn't seem to work.

dwijnand commented 5 years ago

I had a look at the https://github.com/akka/akka-grpc/labels/play label, and they all look like issues related to the Play integration that lives in akka-grpc.

ignasi35 commented 5 years ago

@dwijnand are you referring to the 2 codegen templates in https://github.com/akka/akka-grpc/tree/master/codegen/src/main/twirl/templates? Maybe we should move them out of akka-grpc and promote them here.

raboof commented 5 years ago

@ignasi35 yes, we plan to do that (https://github.com/akka/akka-grpc/issues/517) but there are some PR's in the work for this, so might be smart to postpone that until those are finalized.

dwijnand commented 5 years ago

@ignasi35 yeah those, and I agree the issues should move with the code.

ignasi35 commented 4 years ago

This is complete