search

playframework / play-meta

Team management & cross-repository effort tracking
Apache License 2.0
8 stars 8 forks source link

Change Copyright header #211

Open mkurz opened 2 years ago

mkurz commented 2 years ago

Right now:

Suggestion for new one:

Actually @ihostage came up with the JHipster one in slack. So that is what JHipster uses: https://github.com/jhipster/generator-jhipster/blob/9f8da38a6251416c9b700f35b9533b157d537b4d/cli/commands.js#L2-L5

 * Copyright 2013-2022 the original author or authors from the JHipster project.
 *
 * This file is part of the JHipster project, see https://www.jhipster.tech/
 * for more information.
 *

BTW: This is for source code, on the website they just use:

Repo to update: :question:

octonato commented 2 years ago

2011-2021 Lightbend Inc., since 2022 the original author or authors from the Play Framework project

I find this confusing. I guess the intention is to say, starting from 2022 we consider Lightbend the "original author".

But that's not quite true. The original author is Guillaume.

I think we can just have 

Copyright 2011-2021 (C) Lightbend Inc. <https://www.lightbend.com>

And then add an extra header starting from 2022.

mkurz commented 1 year ago

To finally finish this I suggest:

Copyright from 2022 (C) Contributors to the Play Framework project <https://github.com/playframework>
Copyright 2011-2021 (C) Lightbend Inc. <https://www.lightbend.com>

Taken from https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects

mkurz commented 1 year ago

UPD: content moved into first comment to see a progress on task board

ihostage commented 1 year ago

To finally finish this I suggest:

Copyright from 2022 (C) Contributors to the Play Framework project <https://github.com/playframework>
Copyright 2011-2021 (C) Lightbend Inc. <https://www.lightbend.com>

Taken from https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects

I agree. Although "Copyright (c) The Play Framework Contributors." looks shortly and is liked me more 😄

mkurz commented 1 year ago

liked me more

:wink: I don't care. Actually I am fixing sbt-header right now because it is not working correctly.

mkurz commented 1 year ago

OK, I I was thinking again about this. Let's just do for the main branch

Copyright (C) The Play Framework Contributors <https://github.com/playframework>
// or
Copyright (C) Contributors to the Play Framework project <https://github.com/playframework>

So Lightbend will be dropped (they are contributors also so IMHO they are included in this phrase anyway). No year and the url at the end (using github since that were all other repos are and I want to use phrase for all repos)

ihostage commented 1 year ago

Contributors to the Play Framework project tells that all contributors have had a copyright for all project life. But it's not a true, because until 2021 LB was an exclusive copyrighter 🤔 I'm not a lawyer and don't know how will be correct 🤷‍♂️

mkurz commented 1 year ago

The old copyright header is gone from every repo's main branch (I just checked). Repos that did/do have copyright headers use the new one now. IMHO we can close this issue. We still can set up sbt-header in some repos if we find it useful (for some repos it is not necessary IMHO, e.g. play-samples or the see projects)

@ihostage if you think we should keep it open please let me know.

ihostage commented 1 year ago

I use this issue only to add sbt-header plugin into all repos. But I agree with you that subject "Change Copyright header" is done ✅ I think we can create a separate issue with description as this comment and close this.