playframework / play-meta

Team management & cross-repository effort tracking
Apache License 2.0
8 stars 8 forks source link

In release notes replace all those `...by @mergify` with actual author #216

Closed mkurz closed 1 year ago

mkurz commented 2 years ago

When mergify backports a PR it will always show as ... by @mergify in the release notes. That's a bit annoying since the actual author does not get credit and his/her profile pic will not show up at the bottom of the release notes. Actually we could fix that to make mergify include the author in the title, so in the mergify config we would have to add:

defaults:
    actions:
      backport:
        title:
          - "{{ title }} (backport #{{ number }}) by {{ author }}"

Plus we would have to make release-drafter remove all by @mergify occurences, that should be possible by using replacers: https://github.com/release-drafter/release-drafter/#replacers

Also see https://github.com/playframework/playframework/issues/10965

ihostage commented 2 years ago

@mkurz I think that we have another problem with backport operation. After backporting by comment we don't know a target branch by the title of PR 😞 I'm very like having [2.8.x] as the prefix of title for backporting PR from main to 2.8.x for example. And the same in the opposite direction when we are making forward port from 2.8.x to main. And I don't know can we solve that problem without using backport by label 🤷‍♂️ WDYT?

ihostage commented 2 years ago

Wait... Mergify has a {{ destination_branch }} variable. We can try to use it in the title.

title:
  - "[{{ destination_branch }}] {{ title }} (backport #{{ number }}) by {{ author }}"
mkurz commented 2 years ago

@ihostage https://github.com/playframework/playframework/pull/11167

mkurz commented 2 years ago

We will see at next backport if it works correctly and we can later add this to other repos as well, however I would love to have https://github.com/Mergifyio/mergify-engine/pull/4050

ihostage commented 2 years ago

Yes, of course. 😉 Our target is to use the results of all our single experiments in one place for all repos 😄