search

playframework / play-scala-tls-example

A Play application using HTTPS and WS with optional client authentication
https://developer.lightbend.com/start/?group=play
Creative Commons Zero v1.0 Universal
44 stars 26 forks source link

no jetty-alpn-agent-2.0.6.jar #57

Closed notyy closed 5 years ago

notyy commented 6 years ago

when running ./play run, following error message shows:

Error opening zip file or JAR manifest missing : /Users/twer/source/scala/play-scala-tls-example/target/universal/stage/jetty-alpn-agent/jetty-alpn-agent-2.0.6.jar

should I download the jar and put it to the specified place by myself? or do I missed some step?

marcospereira commented 6 years ago

Hi,

I think we need to update the play script here:

https://github.com/playframework/play-scala-tls-example/blob/fe36bb884da7be92b963aa0fb66646424a5ccbf7/play#L66

Because of https://github.com/playframework/playframework/pull/8243.

We can change it to be more resilient to updates like:

AGENT=$(find $DIR/target/universal/stage/ -name jetty-alpn-agent*.jar | head -1)

Do you mind opening a pull request to fix it?

DavidACL commented 5 years ago

User's issue here is likely that there is no explicit readme instruction to run sbt stage before running ./play run, thus ../jetty-alpn-agent-2.0.6.jar wouldn't be there in any case.

octonato commented 5 years ago

This will be fixed with #71