Upgrade branch 2.6.x using TemplateControl

playframework / play-scala-tls-example

A Play application using HTTPS and WS with optional client authentication

https://developer.lightbend.com/start/?group=play

Creative Commons Zero v1.0 Universal

44 stars 26 forks source link

Upgrade branch 2.6.x using TemplateControl #71

Closed octonato closed 5 years ago

octonato commented 5 years ago

This PR was originally triggered by template control but it evolves into a fix for many errors and improvements that were in place for some time:

fixed cross compilations
remove broken jdk9 build
Resolves #74 - added openjdk11 build, but allowed to fail (see #74)
Fixes #57

marcospereira commented 5 years ago

@renatocaval, since you are removing oraclejdk9 you can remove all the java_version dance in scripts/script-helper.

octonato commented 5 years ago

@marcospereira, I added the dance for jdk11 instead. I also added a build for openjdk11 as suggested by @dwijnand here.

Can you give it a second review?

octonato commented 5 years ago

I blindly added --add-modules=java.xml.bind for Java 11 and the build is now failing with:

Picked up _JAVA_OPTIONS:  --add-modules=java.xml.bind
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
Error occurred during initialization of boot layer
java.lang.module.FindException: Module java.xml.bind not found

Although we do expect Java11 build to fail, I was not expecting it to fail with this.

I'm removing that "dance" for now.

octonato commented 5 years ago

I removed the cross-build. We may eventually add it back when we start to cross-build for 2.13.0-RCx. To decide later...