search

playframework / play-scala-tls-example

A Play application using HTTPS and WS with optional client authentication
https://developer.lightbend.com/start/?group=play
Creative Commons Zero v1.0 Universal
44 stars 26 forks source link

mergify file #77

Closed octonato closed 5 years ago

dwijnand commented 5 years ago

My only questions were:

octonato commented 5 years ago

why split the cleanup rule?

I discovered that if the label is not present, that action 'label' will fail and that will cause the branch to be marked as failed by GitHub. So we need to a condition to only remove the label if the label is present.

And we want to clean-up a branch for every merged PR, also if it was merged manualy and doesn't have a label. So we new to split it otherwise we can't have the second case.

why not have one "automatic merge on CI success" without base branch?

You are right, we don't need to have it per base branch. I will change it.

dwijnand commented 5 years ago

I discovered that if the label is not present, that action 'label' will fail and that will cause the branch to be marked as failed by GitHub. So we need to a condition to only remove the label if the label is present.

And we want to clean-up a branch for every merged PR, also if it was merged manualy and doesn't have a label. So we new to split it otherwise we can't have the second case.

Makes sense. Excellent.