search

playframework / play-slick

Slick Plugin for Play
Apache License 2.0
804 stars 282 forks source link

Documentation mismatch on sample code #398

Open kmcheung12 opened 7 years ago

kmcheung12 commented 7 years ago

In the documentation, it states Play Slick currently supports Slick 3.1 with Play 2.5, for Scala 2.11..

However, in sample code, the slick version used is 3.2.0

slick.driver.JdbcProfile is moved to slick.jdbc.JdbcProfile in slick 3.2.0. It can be confusing when there is no mention which package to be imported in the documentation and the reference implementation is not using the slick version specified in the doc

marcospereira commented 7 years ago

Thanks @kmcheung12.

The documentation page is here: https://github.com/playframework/play-slick/blob/2.1.x/docs/manual/working/scalaGuide/main/sql/slick/PlaySlick.md

Do you want to submit a PR to update it?