playframework / play-ws

Standalone Play WS, an async HTTP client with fluent API
https://www.playframework.com/documentation/latest/JavaWS
Apache License 2.0
223 stars 87 forks source link

logback-core 1.5.0 (was 1.4.14) #846

Closed scala-steward closed 7 months ago

scala-steward commented 7 months ago

About this PR

📦 Updates ch.qos.logback:logback-core from 1.4.14 to 1.5.0

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

âš™ Adjust future updates Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-core" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "ch.qos.logback", artifactId = "logback-core" } }] ```

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

ihostage commented 7 months ago

https://logback.qos.ch/news.html#1.5.0

I don't see a reason not to merge that. @mkurz WDYT?

mkurz commented 7 months ago

@ihostage yes I was also looking at the diff https://github.com/qos-ch/logback/compare/v_1.4.14...v_1.5.0 and I think it's safe. Also they say on the news page

The 1.5.x series is a direct descendant of and a drop-in replacement for the 1.4.x series

So I think we can upgrade and should be fine.