The problem was introduced in 0efba3c556f65e3ba54c9b0ea9319aa58d86f3aa were the assumption was made that the latest netty-reactive-streams version 3 needs to be shaded, however turns out that latest asynchttpclient 2.x still depends on netty-reactive-streams 2.x, so the changing the shading rename rule com.typesafe.netty.** to org.playframework.netty.** does not make sense and ruines the original shading...
With this fix the shading works again (tested locally).
Side note:
Upcoming async-http-client v3 does not depend on netty-reactive-streams anymore, so as soon as we upgrade, we can remove the corresponding shading settings:
Another side note:
We already had a case were we almost ran into a problem because of the fact that async-http-client depends on netty-reactive-streams, but back then we were lucky that selenium dropped the usage of async-http-client.
mkurz
commented
7 months ago
Fixes
862
The problem was introduced in 0efba3c556f65e3ba54c9b0ea9319aa58d86f3aa were the assumption was made that the latest netty-reactive-streams version 3 needs to be shaded, however turns out that latest asynchttpclient 2.x still depends on netty-reactive-streams 2.x, so the changing the shading rename rule
com.typesafe.netty.**toorg.playframework.netty.**does not make sense and ruines the original shading...With this fix the shading works again (tested locally).
Side note: Upcoming async-http-client v3 does not depend on
netty-reactive-streamsanymore, so as soon as we upgrade, we can remove the corresponding shading settings:Another side note: We already had a case were we almost ran into a problem because of the fact that async-http-client depends on netty-reactive-streams, but back then we were lucky that selenium dropped the usage of async-http-client.
So basically with upcoming async-http-client 3 things will improve from itself :wink: