search

playframework / play-ws

Standalone Play WS, an async HTTP client with fluent API
https://www.playframework.com/documentation/latest/JavaWS
Apache License 2.0
223 stars 87 forks source link

[3.0.x] StreamedResponse `headers` map is now case insensitive #909

Closed mkurz closed 3 months ago

mkurz commented 3 months ago
mkurz commented 3 months ago

In Scala 3 we can't override class parameter's "getter"s anymore:

[error] -- [E120] Naming Error: /home/runner/work/play-ws/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/StreamedResponse.scala:56:15 
[error] 56 |  override def headers(): Map[String, scala.collection.Seq[String]] = {
[error]    |               ^
[error]    |Double definition:
[error]    |private[this] val headers: Map[String, scala.collection.Seq[String]] in class StreamedResponse at line 45 and
[error]    |override def headers(): Map[String, scala.collection.Seq[String]] in class StreamedResponse at line 56
[error] one error found
mkurz commented 3 months ago

@Mergifyio backport main

mergify[bot] commented 3 months ago

backport main

✅ Backports have been created

* [#912 [main] [3.0.x] StreamedResponse `headers` map is now case insensitive (backport #909) by @mkurz](https://github.com/playframework/play-ws/pull/912) has been created for branch `main`
mkurz commented 3 months ago

@Mergifyio backport 2.2.x

mergify[bot] commented 3 months ago

backport 2.2.x

✅ Backports have been created

* [#913 [2.2.x] [3.0.x] StreamedResponse `headers` map is now case insensitive (backport #909) by @mkurz](https://github.com/playframework/play-ws/pull/913) has been created for branch `2.2.x`