playframework / play1

Play framework
https://www.playframework.com/documentation/1.4.x/home
Other
1.58k stars 682 forks source link

[#1403] šŸ› Fix Groovy compilation unit that tries to write in applicatā€¦ #1406

Closed holajsh closed 2 years ago

holajsh commented 2 years ago

Fix Groovy compilation unit that tries to write in application root folder

Fixes

Fixes #1403

tazmaniax commented 2 years ago

@holajsh here was the previous pull request #1368 to fix this that was some how lost. Note the comment that was included in the previous fix - probably worth bringing in that whole change as it was. It's bit disconcerting that this previous PR was lost.

holajsh commented 2 years ago

@tazmaniax ok, I have added the comment again in my PR, thx. Hope indeed it won't be lost again ;)

tomparle commented 2 years ago

@holajsh here was the previous pull request #1368 to fix this that was some how lost. Note the comment that was included in the previous fix - probably worth bringing in that whole change as it was. It's bit disconcerting that this previous PR was lost.

@tazmaniax my bad, although I tried my best I think I'm responsible for having messed this code when I rebased the Python 3 PR with master, because I got confused with what was new or not, since it was a revert to a previous code. Sorry and thank you for having detected and fixed this !

tazmaniax commented 2 years ago

@tomparle ah that's good to know where the regression might have come from, thanks for the heads up. So do you think this was the only regression or could there be others?

tomparle commented 2 years ago

@tazmaniax to be honest, I tried to be careful with the rest of the code, but remembered the Groovy compilation part in particular because I was puzzled between new and old code. The rest should be ok.

tazmaniax commented 2 years ago

@tomparle ok great!