search

playframework / play1

Play framework
https://www.playframework.com/documentation/1.4.x/home
Other
1.58k stars 682 forks source link

Updated 3rd party dependencies #1448

Closed tazmaniax closed 11 months ago

tazmaniax commented 1 year ago

All tests pass

tazmaniax commented 1 year ago

This is compiling successfully using JDK 20 so maybe the minimum JDK has been increased and the following libs must be reverted to 3.33.0. More investigation is needed.

- org.eclipse.jdt -> org.eclipse.jdt.core 3.34.0
- org.eclipse.jdt -> ecj 3.34.0
tazmaniax commented 1 year ago

@xael-fry I've confirmed that Eclipse JDT compiler v0.33.0 is the last version supporting Java 11 and Java 17 is the new minimum for later compiler versions. Otherwise, this is good to go. Cheers

tazmaniax commented 1 year ago

Confirmed again that post JDT v3.33.0 versions (in this case v3.35.0) do not work with Java 11. It would be nice if the Java 17 builds would happen even if the Java 11 build fails to show that it does work for later versions of Java

CleanShot 2023-09-15 at 09 58 18@2x