search

playframework / twirl

Twirl is Play's default template engine
Apache License 2.0
549 stars 108 forks source link

compileVirtual should not depend on `File` object to template #143

Open unoexperto opened 7 years ago

unoexperto commented 7 years ago

I think TwirlCompiler.compileVirtual should not depend on File object to template because internally it's used only to generate template name. This prevent clients from compiling twirl templates on the fly. In my case I'd like admins of web-service to be able to update templates via API which are stored in DB.

mkurz commented 7 years ago

@unoexperto How about a pull request? :smile: