playframework / twirl

Twirl is Play's default template engine
Apache License 2.0
549 stars 108 forks source link

Fix problems regarding Scala 3 and sourcePositionMapper #498

Open mkurz opened 2 years ago

mkurz commented 2 years ago

See

Following commit could then be reverted eventually: https://github.com/playframework/twirl/commit/e892f83f9b97a56cddafd50e59bd88f9bbaf8557

tototoshi commented 2 years ago

The pull request I sent to sbt/zinc has been merged. Hopefully, the next release will fix the problem.

mkurz commented 2 years ago

@tototoshi Nice :+1: BTW, did you see https://github.com/sbt/sbt/discussions/6868, I didn't look into all of that, however has this something to do with our problem?

tototoshi commented 2 years ago

Yes, I am interested in this proposal. I don't think that this proposal can be a solution to our problem with sourcePositionMappers. However, it will be a help to make Twirl error messages more friendly in the future.