Support >22 args in Scala 3

playframework / twirl

Twirl is Play's default template engine

Apache License 2.0

545 stars 108 forks source link

Support >22 args in Scala 3 #747

Closed mkurz closed 6 months ago

mkurz commented 6 months ago

~~Try to fix~~ Fixes

~~This is WIP.~~

If this works

[ ] ~~theTemplate.scala should be moved into a scala-2.13 (also scala-2.12?) folder and~~
[x] in the twirl compiler we can just make use of the ScalaCompat sc parameter to decide wheter we need to add ... with _root_.play.twirl.api.TemplateX[...] or not to stay compatible with Scala 2.13.
[ ] ~~Also MiMa filters need to be adjusted.~~

mkurz commented 6 months ago

Fix was quite easy and we can even ship it in a patch release. Also added tests :+1:

mkurz commented 6 months ago

@Mergifyio backport 1.6.x

mergify[bot] commented 6 months ago

backport 1.6.x

✅ Backports have been created

* [#748 [1.6.x] Support >22 args in Scala 3 (backport #747) by @mkurz](https://github.com/playframework/twirl/pull/748) has been created for branch `1.6.x` but encountered conflicts

playframework / twirl

Support >22 args in Scala 3 #747

722

✅ Backports have been created