search

playgameservices / android-basic-samples

Google Play game services - Android samples
Apache License 2.0
972 stars 970 forks source link

BaseGameUtils#showActivityResultError is requesting a String resource Id instead of result of isGooglePlayServicesAvailable #116

Closed william-ferguson-au closed 9 years ago

william-ferguson-au commented 9 years ago

One of the inputs for BaseGameUtils#showActivityResultError is errorCode, whose description is @param errorCode the resource id of a String for an 'Unable to sign in' error message

But this value is passed to GooglePlayServicesUtil.getErrorDialog(errorCode, activity, requestCode, null) which is expecting errorCode to be the output of GooglePlayServices.isGooglePlayServicesAvailable()

See http://developer.android.com/reference/com/google/android/gms/common/GooglePlayServicesUtil.html#getErrorDialog(int, android.app.Activity, int)

So this call will always fail, badly.

cesards commented 9 years ago

+1

samtstern commented 9 years ago

117 fixed this. Closing.