search

playgameservices / android-basic-samples

Google Play game services - Android samples
Apache License 2.0
972 stars 970 forks source link

Fix for issue-116 #117

Closed william-ferguson-au closed 9 years ago

william-ferguson-au commented 9 years ago

Replaced String resource errorCode with the result from GooglePlayServicesUtil.isGooglePlayServicesAvailable() which is what is actually needed.

william-ferguson-au commented 9 years ago

NB you'll want to update the docs at https://developers.google.com/games/services/android/init too.

samtstern commented 9 years ago

Thanks a lot for taking the time to write this PR. Looks like we made this mistake once and then copy-pasted it through when we were updating all of the samples not to use BaseGameActivity.

I'm to merge this as-is, but first you will need to sign this CLA. This is required for all contributions to our repositories, and it doesn't look like you have previously signed this.

william-ferguson-au commented 9 years ago

Done - Glad I could help.

On Mon, Nov 24, 2014 at 9:29 AM, Sam Stern notifications@github.com wrote:

Thanks a lot for taking the time to write this PR. Looks like we made this mistake once and then copy-pasted it through when we were updating all of the samples not to use BaseGameActivity.

I'm to merge this as-is, but first you will need to sign this CLA https://cla.developers.google.com/clas. This is required for all contributions to our repositories, and it doesn't look like you have previously signed this.

— Reply to this email directly or view it on GitHub https://github.com/playgameservices/android-basic-samples/pull/117#issuecomment-64230438 .

googlebot commented 9 years ago

CLAs look good, thanks!