krez01 commented 8 years ago

in ButtonClicker

commit 1: roomId need to initialize in onConnectedToRoom(Room room) as this callback will surely call in all players app rather than in onRoomCreated(int statusCode, Room room) which guarantees to call only in the player who initiate play invitation or room creation for other players.

commit 2: To avoid crash of application from ignored invitation request like closing application just when invitation pop up (edge case appeared in some use case)

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

krez01 commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

claywilkinson commented 8 years ago

Thanks! a couple minor comments.

krez01 commented 8 years ago

hey done

playgameservices / android-basic-samples

bug fix of room initialization and invitation popup from crashing app #184

in ButtonClicker

commit 1: roomId need to initialize in onConnectedToRoom(Room room) as this callback will surely call in all players app rather than in onRoomCreated(int statusCode, Room room) which guarantees to call only in the player who initiate play invitation or room creation for other players.

commit 2: To avoid crash of application from ignored invitation request like closing application just when invitation pop up (edge case appeared in some use case)