playgameservices / cpp-android-basic-samples

Sample games using the Google Play Games C++ SDK
302 stars 133 forks source link

made ButtonClicker target abi armeabi-v7a rather than arm64-v8a #33

Closed jknight-nc closed 8 years ago

jknight-nc commented 8 years ago

https://github.com/playgameservices/cpp-android-basic-samples/issues/32

I don't think ButtonClicker should target arm64-v8a by default. That ABI is very niche. Most devices can emulate armeabi-v7a if they dont support it natively. This makes much more sense.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jknight-nc commented 8 years ago

I'm going to sign this from my personal email and github account.